Unable to scrub album after adding it to the playlist #72

New issue

Closed

opened 2020-08-02 15:13:53 +02:00 by oenometer · 5 comments

oenometer commented

2020-08-02 15:13:53 +02:00

(Migrated from gitlab.com)

Immediately after an album is played, the timeline bar in the Cover tab does not allow you to scrub through the album.

Steps to reproduce:

Click an album cover in the library tab, then hit the play button
Switch to the Cover tab
Attempt to scrub through the album using the vertical timeline
The timeline can be reactivated by pausing and playing the song

Found on MCG version 2.1, on Archlinux using both the AUR package, and when built using setuptools

Immediately after an album is played, the timeline bar in the Cover tab does not allow you to scrub through the album. Steps to reproduce: 1. Click an album cover in the library tab, then hit the play button 2. Switch to the Cover tab 3. Attempt to scrub through the album using the vertical timeline 4. The timeline can be reactivated by pausing and playing the song Found on MCG version 2.1, on Archlinux using both the AUR package, and when built using setuptools

oenometer commented

2020-08-02 15:18:07 +02:00

(Migrated from gitlab.com)

changed the description

coderkun commented

2020-08-02 17:40:54 +02:00

(Migrated from gitlab.com)

mentioned in commit 973d3dd921

mentioned in commit 973d3dd921fe3ca97151ed6b34f5fa73e8f3dbf3

coderkun commented

2020-08-02 17:41:54 +02:00

(Migrated from gitlab.com)

Thanks for reporting this issue. I can reproduce it and see the following error message:

Traceback (most recent call last):
  File "/home/oliver/Dokumente/Coding/mcg/mcg/widgets.py", line 1074, in on_songs_change
    pos = tracks[index].get_pos()
AttributeError: 'MCGTrack' object has no attribute 'get_pos'

Would you mind testing the fix on branch issue-72-fix-skipping?

Thanks for reporting this issue. I can reproduce it and see the following error message: Traceback (most recent call last): File "/home/oliver/Dokumente/Coding/mcg/mcg/widgets.py", line 1074, in on_songs_change pos = tracks[index].get_pos() AttributeError: 'MCGTrack' object has no attribute 'get_pos' Would you mind testing the fix on branch `issue-72-fix-skipping`?

oenometer commented

2020-08-03 15:30:46 +02:00

(Migrated from gitlab.com)

I can confirm the change in issue-72-fix-skipping has resolved the issue.

I noticed an associated bug, where the album_artist was printed as a feature on every song in the cover tab, but only on certain albums. Looks like this stemmed from the same use of the MCGTrack class in place of the MCGPlaylistTrack. With the change in issue-72-fix-skipping this issue is now resolved as well.

Appreciate your quick fix!

I can confirm the change in `issue-72-fix-skipping` has resolved the issue. I noticed an associated bug, where the album_artist was printed as a feature on every song in the cover tab, but only on certain albums. Looks like this stemmed from the same use of the MCGTrack class in place of the MCGPlaylistTrack. With the change in `issue-72-fix-skipping` this issue is now resolved as well. Appreciate your quick fix!

coderkun commented

2020-08-03 16:31:43 +02:00

(Migrated from gitlab.com)

Thanks, @oenometer, I merged it and will release it as version 2.1.2.

Nice to see that the related bug—which I occasionally noticed, too, but didn’t track down—has been fixed, too.

Thanks, @oenometer, I merged it and will release it as version 2.1.2. Nice to see that the related bug—which I occasionally noticed, too, but didn’t track down—has been fixed, too.