Feature request: allow display by "recently added" #88

Closed
opened 2023-01-08 15:51:40 +01:00 by alan12345678 · 11 comments
alan12345678 commented 2023-01-08 15:51:40 +01:00 (Migrated from gitlab.com)

My preferred player - also an mpd client - is no longer developed. Swapping to MCG it looks great right off the bat, fits perfectly where previous player left off! However the ONE thing I'd always taken for granted was that album display is by "latest added" - meaning that new items don't just disappear into alphabet hell, but stay at the top. With larger collections I find this so desirable.

Would it be possible to implement this at all?

My preferred player - also an mpd client - is no longer developed. Swapping to MCG it looks great right off the bat, fits perfectly where previous player left off! However the ONE thing I'd always taken for granted was that album display is by "latest added" - meaning that new items don't just disappear into alphabet hell, but stay at the top. With larger collections I find this so desirable. Would it be possible to implement this at all?
coderkun commented 2023-01-08 18:10:58 +01:00 (Migrated from gitlab.com)

Hi @alan12345678, thanks for the request. First, I need to see if MPD provides this information. If it does, I can provide a sort option for it.

Hi @alan12345678, thanks for the request. First, I need to see if MPD provides this information. If it does, I can provide a sort option for it.
coderkun commented 2023-01-08 18:19:47 +01:00 (Migrated from gitlab.com)

It looks like MPD provides the last modification date via [Other Metadata(https://mpd.readthedocs.io/en/latest/protocol.html#other-metadata).

It looks like MPD provides the last modification date via [Other Metadata(https://mpd.readthedocs.io/en/latest/protocol.html#other-metadata).
alan12345678 commented 2023-01-08 18:25:49 +01:00 (Migrated from gitlab.com)

ooh! So, does this means it's do-able? That's hugely cool if so 😄

ooh! So, does this means it's do-able? That's hugely cool if so :smile:
coderkun commented 2023-01-08 19:04:07 +01:00 (Migrated from gitlab.com)

Yes, it is doable.

Yes, it is doable.
coderkun commented 2023-01-08 19:10:34 +01:00 (Migrated from gitlab.com)

mentioned in commit 87fcf3937de148b5a1ec099d3c0d741517abf469

mentioned in commit 87fcf3937de148b5a1ec099d3c0d741517abf469
coderkun commented 2023-01-08 19:13:52 +01:00 (Migrated from gitlab.com)

@alan12345678, the sort option has been implemented on branch “issue-88-sort-by-modified”. Would you mind checking out that branch and testing if it works as expected?

@alan12345678, the sort option has been implemented on branch “issue-88-sort-by-modified”. Would you mind checking out that branch and testing if it works as expected?
coderkun commented 2023-01-08 19:52:54 +01:00 (Migrated from gitlab.com)

assigned to @coderkun

assigned to @coderkun
alan12345678 commented 2023-01-08 19:59:41 +01:00 (Migrated from gitlab.com)

Yes! Indeed it does 😄

I have a separate, prior issue which perhaps you'd be kind enough to help. I've asked on another forum but no replies thus far.

I run a fairly minimal environment, not via a DM. Arch + i3. No login manager, I log in at console, source .xinitrc and straight into i3, which starts a couple apps. My .xinitrc sets up just kbd, compton, policykit, feh and mpd, nothing else.

Every time I start mcg it has to rebuild the album list, and regenerate all the album art! Then, when loaded, most covers are simply the supplied placeholder graphic. A few random covers appear.

Terminal messages say this:

`(mcg:10741): Gtk-CRITICAL **: 19:46:27.578: gtk_window_add_accel_group: assertion 'GTK_IS_WINDOW (window)' failed

(mcg:10741): GLib-GIO-CRITICAL **: 19:46:52.523: g_settings_set_enum(): invalid enum value 3 for key 'sort-order' in schema 'xyz.suruatoel.mcg'. Doing nothing.
2023-01-08 19:47:18,693 ERROR: Failed to load albumart
Traceback (most recent call last):
File "/usr/local/share/mcg/mcg/librarypanel.py", line 494, in _set_albums
pixbuf = Utils.load_thumbnail(cache, self.client, album, size)
File "/usr/local/share/mcg/mcg/utils.py", line 38, in load_thumbnail
albumart = client.get_albumart_now(album.get_id())
File "/usr/local/share/mcg/mcg/client.py", line 318, in get_albumart_now
(
, albumart) = future.result()
TypeError: cannot unpack non-iterable NoneType object
`

Should I have some other services running? I have the listed deps installed.

Yes! Indeed it does :smile: I have a separate, prior issue which perhaps you'd be kind enough to help. I've asked on another forum but no replies thus far. I run a fairly minimal environment, not via a DM. Arch + i3. No login manager, I log in at console, source .xinitrc and straight into i3, which starts a couple apps. My .xinitrc sets up just kbd, compton, policykit, feh and mpd, nothing else. Every time I start mcg it has to rebuild the album list, and regenerate all the album art! Then, when loaded, most covers are simply the supplied placeholder graphic. A few random covers appear. Terminal messages say this: `(mcg:10741): Gtk-CRITICAL **: 19:46:27.578: gtk_window_add_accel_group: assertion 'GTK_IS_WINDOW (window)' failed (mcg:10741): GLib-GIO-CRITICAL **: 19:46:52.523: g_settings_set_enum(): invalid enum value 3 for key 'sort-order' in schema 'xyz.suruatoel.mcg'. Doing nothing. 2023-01-08 19:47:18,693 ERROR: Failed to load albumart Traceback (most recent call last): File "/usr/local/share/mcg/mcg/librarypanel.py", line 494, in _set_albums pixbuf = Utils.load_thumbnail(cache, self._client, album, size) File "/usr/local/share/mcg/mcg/utils.py", line 38, in load_thumbnail albumart = client.get_albumart_now(album.get_id()) File "/usr/local/share/mcg/mcg/client.py", line 318, in get_albumart_now (_, albumart) = future.result() TypeError: cannot unpack non-iterable NoneType object ` Should I have some other services running? I have the listed deps installed.
coderkun commented 2023-01-09 09:09:55 +01:00 (Migrated from gitlab.com)

In fact I use a similar setup only that I use sway instead of i3. Do you get TypeError: cannot unpack non-iterable NoneType object only on the feature branch or also on the main branch/the released version 3.1?

In fact I use a similar setup only that I use sway instead of i3. Do you get `TypeError: cannot unpack non-iterable NoneType object` only on the feature branch or also on the main branch/the released version 3.1?
alan12345678 commented 2023-01-09 17:54:24 +01:00 (Migrated from gitlab.com)

I get these errors on either version.

Last night I added both the gsettings-desktop-schema, and desktop-file-utils to the i3 startup, but no chamge. The database is recreated each time, and most album covers don't show up (not all, but most). Music plays fine, album listing all correct, but no art.

I get these errors on either version. Last night I added both the gsettings-desktop-schema, and desktop-file-utils to the i3 startup, but no chamge. The database is recreated each time, and most album covers don't show up (not all, but most). Music plays fine, album listing all correct, but no art.
coderkun commented 2023-01-10 08:43:07 +01:00 (Migrated from gitlab.com)

If it affects the released version, please create a separate issue. I am going to merge and release this new feature.

If it affects the released version, please create a separate issue. I am going to merge and release this new feature.
Sign in to join this conversation.
No description provided.