From 013df79c6e9b67e70477da13af5c2adeeb0cd09c Mon Sep 17 00:00:00 2001 From: coderkun Date: Sat, 17 May 2014 15:29:54 +0200 Subject: [PATCH] do not use empty in non-write context --- controllers/QuestsController.inc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/controllers/QuestsController.inc b/controllers/QuestsController.inc index cd69d925..87d158b8 100644 --- a/controllers/QuestsController.inc +++ b/controllers/QuestsController.inc @@ -86,8 +86,10 @@ $selectedQuesttype = null; if($this->request->getRequestMethod() == 'GET') { - $selectedQuestgroup = !empty($this->request->getGetParam('questgroup')) ? $this->request->getGetParam('questgroup') : null; - $selectedQuesttype = !empty($this->request->getGetParam('questtype')) ? $this->request->getGetParam('questtype') : null; + $selectedQuestgroup = $this->request->getGetParam('questgroup'); + $selectedQuestgroup = !empty($selectedQuestgroup) ? $selectedQuestgroup : null; + $selectedQuesttype = $this->request->getGetParam('questtype'); + $selectedQuesttype = !empty($selectedQuesttype) ? $selectedQuesttype : null; } // Get Quests