From 0f482f0d2d1afc5da95af055c3b01f9b6347de11 Mon Sep 17 00:00:00 2001 From: oliver Date: Tue, 14 Jul 2015 16:01:40 +0200 Subject: [PATCH] correct checking of Achievements (fixes #107) --- controllers/CharactergroupsquestsController.inc | 13 +++++-------- controllers/QuestsController.inc | 4 ++-- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/controllers/CharactergroupsquestsController.inc b/controllers/CharactergroupsquestsController.inc index 886b220f..21c1778e 100644 --- a/controllers/CharactergroupsquestsController.inc +++ b/controllers/CharactergroupsquestsController.inc @@ -212,14 +212,11 @@ $characters = $this->Characters->getCharactersForGroup($group['id']); foreach($characters as &$character) { - if($character['id'] != $this->Auth->getUserId()) - { - $this->Achievement->checkAchievements( - $seminary['id'], - $character['id'], - array('character', 'achievement') - ); - } + $this->Achievement->checkAchievements( + $seminary['id'], + $character['id'], + array('character', 'achievement') + ); } } } diff --git a/controllers/QuestsController.inc b/controllers/QuestsController.inc index e07d3bc7..76da59c2 100644 --- a/controllers/QuestsController.inc +++ b/controllers/QuestsController.inc @@ -77,8 +77,8 @@ { parent::preFilter($request, $response); - $this->checkAchievements($request, $response, array('character', 'quest')); - $this->checkAchievements($request, $response, 'achievement'); + $this->checkAchievements($request, array('character', 'quest')); + $this->checkAchievements($request, 'achievement'); }