coderkun/questlab
1
0
Fork 0
Code Issues 15 Pull requests Projects Releases Wiki Activity

correct cache control for media

Browse source
This commit is contained in:
coderkun 2014-05-06 17:55:30 +02:00
commit 56d807f925
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
controllers/MediaController.inc
View file

@ -62,8 +62,7 @@
// Set headers for caching control // Set headers for caching control
$response->addHeader("Pragma: public"); $response->addHeader("Pragma: public");
$response->addHeader("Cache-control: public, max-age=".(60*60*24)); $response->addHeader("Cache-control: must-revalidate");
$response->addHeader("Expires: ".gmdate('r', time()+(60*60*24)));
$response->addHeader("Date: ".gmdate(\DateTime::RFC822)); $response->addHeader("Date: ".gmdate(\DateTime::RFC822));
} }
@ -302,7 +301,7 @@
$headerModifiedSince = $this->request->getServerParam('HTTP_IF_MODIFIED_SINCE'); $headerModifiedSince = $this->request->getServerParam('HTTP_IF_MODIFIED_SINCE');
$headerNoneMatch = $this->request->getServerParam('HTTP_IF_NONE_MATCH'); $headerNoneMatch = $this->request->getServerParam('HTTP_IF_NONE_MATCH');
if( if(
!is_null($headerModifiedSince) && $fileLastModified < strtotime($headerModifiedSince) && !is_null($headerModifiedSince) && strtotime($fileLastModified) <= strtotime($headerModifiedSince) &&
!is_null($headerNoneMatch) && $headerNoneMatch == $fileEtag !is_null($headerNoneMatch) && $headerNoneMatch == $fileEtag
) { ) {
$this->response->setExit(true); $this->response->setExit(true);