coderkun/questlab
1
0
Fork 0
Code Issues 15 Pull requests Projects Releases Wiki Activity

do not use empty() without write-context

Browse source
This commit is contained in:
coderkun 2014-04-24 12:38:52 +02:00
commit bf169305a7
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
controllers/CharactersController.inc
View file

@ -291,7 +291,7 @@
// Do action // Do action
$selectedCharacters = array(); $selectedCharacters = array();
if($this->request->getRequestMethod() == 'POST' && !empty($this->request->getPostParam('actions')) && !empty($this->request->getPostParam('characters'))) if($this->request->getRequestMethod() == 'POST' && !is_null($this->request->getPostParam('actions')) && count($this->request->getPostParam('actions')) > 0 && !is_null($this->request->getPostParam('characters')) && count($this->request->getPostParam('characters')) > 0)
{ {
$actions = $this->request->getPostParam('actions'); $actions = $this->request->getPostParam('actions');
$action = array_keys($actions)[0]; $action = array_keys($actions)[0];