store the total amount of achievable XPs for a Questgroup in the database instead of calculating it every time (Issue #281)

This commit is contained in:
coderkun 2014-05-15 18:17:51 +02:00
commit ea828a88dc
10 changed files with 211 additions and 209 deletions

View file

@ -61,7 +61,7 @@
if(is_null($parentQuestgroupId))
{
$questgroups = $this->db->query(
'SELECT questgroups.id, questgroups_questgroupshierarchy.questgroupshierarchy_id, questgroups_questgroupshierarchy.pos, questgroups.title, questgroups.url, questgroups.questgroupspicture_id '.
'SELECT questgroups.id, questgroups_questgroupshierarchy.questgroupshierarchy_id, questgroups_questgroupshierarchy.pos, questgroups.title, questgroups.url, questgroups.questgroupspicture_id, questgroups.achievable_xps '.
'FROM questgroups_questgroupshierarchy '.
'INNER JOIN questgroups ON questgroups.id = questgroups_questgroupshierarchy.questgroup_id '.
'WHERE questgroups_questgroupshierarchy.questgroupshierarchy_id = ? AND questgroups_questgroupshierarchy.parent_questgroup_id IS NULL '.
@ -73,7 +73,7 @@
else
{
$questgroups = $this->db->query(
'SELECT questgroups.id, questgroups_questgroupshierarchy.questgroupshierarchy_id, questgroups_questgroupshierarchy.pos, questgroups.title, questgroups.url, questgroups.questgroupspicture_id '.
'SELECT questgroups.id, questgroups_questgroupshierarchy.questgroupshierarchy_id, questgroups_questgroupshierarchy.pos, questgroups.title, questgroups.url, questgroups.questgroupspicture_id, questgroups.achievable_xps '.
'FROM questgroups_questgroupshierarchy '.
'INNER JOIN questgroups ON questgroups.id = questgroups_questgroupshierarchy.questgroup_id '.
'WHERE questgroups_questgroupshierarchy.questgroupshierarchy_id = ? AND questgroups_questgroupshierarchy.parent_questgroup_id = ? '.
@ -98,7 +98,7 @@
public function getQuestgroupsForSeminary($seminaryId)
{
return $this->db->query(
'SELECT id, title, url '.
'SELECT id, title, url, achievable_xps '.
'FROM questgroups '.
'WHERE seminary_id = ? '.
'ORDER BY title ASC',
@ -118,7 +118,7 @@
public function getQuestgroupById($questgroupId)
{
$data = $this->db->query(
'SELECT id, title, url, questgroupspicture_id '.
'SELECT id, title, url, questgroupspicture_id, achievable_xps '.
'FROM questgroups '.
'WHERE questgroups.id = ?',
'i',
@ -144,7 +144,7 @@
public function getQuestgroupByUrl($seminaryId, $questgroupUrl)
{
$data = $this->db->query(
'SELECT id, title, url, questgroupspicture_id '.
'SELECT id, title, url, questgroupspicture_id, achievable_xps '.
'FROM questgroups '.
'WHERE seminary_id = ? AND url = ?',
'is',
@ -428,113 +428,6 @@
/**
* Calculate cumulated data for a Questgroup, its
* sub-Questgroups and all its Quests.
*
* @param int $questgroupId ID of Questgroup
* @param int $characterId ID of Character
* @param array $calculatedQuests IDs of already calculated Quests
* @return array Cumulated data for Questgroup
*/
public function getCumulatedDataForQuestgroup($questgroupId, $characterId=null, &$calculatedQuests=array())
{
// Cumulated data
$data = array(
'xps' => 0,
'character_xps' => 0
);
// Current Questgroup
$questgroup = $this->getQuestgroupById($questgroupId);
// Quests of current Questgroup
$quest = $this->Quests->getFirstQuestOfQuestgroup($questgroup['id']);
if(!is_null($quest))
{
$questData = $this->getCumulatedDataForQuest($quest, $characterId, $calculatedQuests);
$data['xps'] += $questData['xps'];
$data['character_xps'] += $questData['character_xps'];
}
// XPs of child Questgroups
$questgroupHierarchy = $this->Questgroupshierarchy->getHierarchyForQuestgroup($questgroup['id']);
if(!empty($questgroupHierarchy))
{
$childQuestgroupshierarchy = $this->Questgroupshierarchy->getChildQuestgroupshierarchy($questgroupHierarchy['id']);
foreach($childQuestgroupshierarchy as &$hierarchy)
{
$questgroups = $this->getQuestgroupsForHierarchy($hierarchy['id'], $questgroup['id']);
foreach($questgroups as &$questgroup)
{
$childData = $this->getCumulatedDataForQuestgroup($questgroup['id'], $characterId, $calculatedQuests);
$data['xps'] += $childData['xps'];
$data['character_xps'] += $childData['character_xps'];
}
}
}
// Return cumulated data
return $data;
}
/**
* Calculate cumulated data of the given Quest, its following
* Quests and its related Questgroups.
*
* @param array $quest Quest data
* @param int $characterId ID of Character
* @param array $calculatedQuests IDs of already calculated Quests
* @return array Cumulated data for Quest
*/
public function getCumulatedDataForQuest($quest, $characterId=null, &$calculatedQuests=array())
{
// Cumulated data
$data = array(
'xps' => $quest['xps'],
'character_xps' => (!is_null($characterId) && $this->Quests->hasCharacterSolvedQuest($quest['id'], $characterId)) ? $quest['xps'] : 0
);
// Related Questgroups
$relatedQuestgroups = $this->getRelatedQuestsgroupsOfQuest($quest['id']);
foreach($relatedQuestgroups as &$relatedQuestgroup)
{
$relatedData = $this->getCumulatedDataForQuestgroup($relatedQuestgroup['id'], $characterId, $calculatedQuests);
$data['xps'] += $relatedData['xps'];
$data['character_xps'] += $relatedData['character_xps'];
}
// Next Quests
$nextQuests = $this->Quests->getNextQuests($quest['id']);
$allNextData = array(
'xps' => array(0),
'character_xps' => array(0),
);
foreach($nextQuests as &$nextQuest)
{
if(!array_key_exists($nextQuest['id'], $calculatedQuests))
{
$nextData = $this->getCumulatedDataForQuest($nextQuest, $characterId, $calculatedQuests);
$calculatedQuests[$nextQuest['id']] = array(
'xps' => $nextData['xps'],
'character_xps' => $nextData['character_xps']
);
}
$allNextData['xps'][] = $calculatedQuests[$nextQuest['id']]['xps'];
$allNextData['character_xps'][] = $calculatedQuests[$nextQuest['id']]['character_xps'];
}
$data['xps'] += max($allNextData['xps']);
$data['character_xps'] += max($allNextData['character_xps']);
// Return cumulated data
return $data;
}
/**
* Summarize XPs of all Quests for a Questgroup and its
* sub-Questgroups solved by a Character.
*
@ -544,75 +437,29 @@
*/
public function getAchievedXPsForQuestgroup($questgroupId, $characterId)
{
// Sum of XPs
$xps = 0;
// Questgroup
$xps = $this->_getAchievedXPsForQuestgroup($questgroupId, $characterId);
// Current Questgroup
$questgroup = $this->getQuestgroupById($questgroupId);
// Quests of current Questgroup
$quest = $this->Quests->getFirstQuestOfQuestgroup($questgroup['id']);
if(!is_null($quest)) {
$xps += $this->getAchievedXPsForQuest($quest, $characterId);
// Related Questgroups
foreach($this->getRelatedQuestsgroupsOfQuestgroup($questgroupId) as $relatedQuestgroup) {
$xps += $this->getAchievedXPsForQuestgroup($relatedQuestgroup['id'], $characterId);
}
// XPs of child Questgroups
$questgroupHierarchy = $this->Questgroupshierarchy->getHierarchyForQuestgroup($questgroup['id']);
if(empty($questgroupHierarchy)) {
return $xps;
}
$childQuestgroupshierarchy = $this->Questgroupshierarchy->getChildQuestgroupshierarchy($questgroupHierarchy['id']);
foreach($childQuestgroupshierarchy as &$hierarchy)
$questgroupHierarchy = $this->Questgroupshierarchy->getHierarchyForQuestgroup($questgroupId);
if(!empty($questgroupHierarchy))
{
$questgroups = $this->getQuestgroupsForHierarchy($hierarchy['id'], $questgroup['id']);
foreach($questgroups as &$questgroup) {
$xps += $this->getAchievedXPsForQuestgroup($questgroup['id'], $characterId);
}
}
// Return summarized XPs
return $xps;
}
/**
* Summarize XPs of the given Quest, its following Quests and
* its related Questgroups solved by a Character.
*
* @param int $quest Quest to summarize XPs for
* @param int $characterId ID of Character
* @return int Sum of XPs
*/
public function getAchievedXPsForQuest($quest, $characterId)
{
$xps = 0;
// XPs for the given Quest
if($this->Quests->hasCharacterSolvedQuest($quest['id'], $characterId))
{
$xps += $quest['xps'];
// Next Quests
$nextQuests = $this->Quests->getNextQuests($quest['id']);
foreach($nextQuests as &$nextQuest)
$childQuestgroupshierarchy = $this->Questgroupshierarchy->getChildQuestgroupshierarchy($questgroupHierarchy['id']);
foreach($childQuestgroupshierarchy as &$hierarchy)
{
if($this->Quests->hasCharacterEnteredQuest($nextQuest['id'], $characterId))
{
$xps += $this->getAchievedXPsForQuest($nextQuest, $characterId);
break;
$childQuestgroups = $this->getQuestgroupsForHierarchy($hierarchy['id'], $questgroupId);
foreach($childQuestgroups as &$childQuestgroup) {
$xps += $this->getAchievedXPsForQuestgroup($childQuestgroup['id'], $characterId);
}
}
}
// Related Questgroups
$relatedQuestgroups = $this->getRelatedQuestsgroupsOfQuest($quest['id']);
foreach($relatedQuestgroups as &$relatedQuestgroup) {
$xps += $this->getAchievedXPsForQuestgroup($relatedQuestgroup['id'], $characterId);
}
// Return summarized XPs
return $xps;
}
@ -766,6 +613,130 @@
);
}
/**
* Calculate the total amount of achievable XPs for a
* Questgroup, its sub-Questgroups, related Questgroups etc. and
* store this value in the database.
*
* @param int $questgroupId ID of Questgroup
* @param array $calculatedQuests Already calculated Quests
* @return int Sum of calculated XPs
*/
public function calculateXPsForQuestgroup($questgroupId, &$calculatedQuests=array())
{
$xps = 0;
// Quests
$quest = $this->Quests->getFirstQuestOfQuestgroup($questgroupId);
if(!is_null($quest)) {
$xps = $this->_calculateXPsForQuestgroup($quest);
}
// Child Questgroups
$questgroupHierarchy = $this->Questgroupshierarchy->getHierarchyForQuestgroup($questgroupId);
if(!empty($questgroupHierarchy))
{
$childQuestgroupshierarchy = $this->Questgroupshierarchy->getChildQuestgroupshierarchy($questgroupHierarchy['id']);
foreach($childQuestgroupshierarchy as &$hierarchy)
{
$questgroups = $this->getQuestgroupsForHierarchy($hierarchy['id'], $questgroupId);
foreach($questgroups as &$questgroup) {
$xps += $this->calculateXPsForQuestgroup($questgroup['id'], $calculatedQuests);
}
}
}
// Save XPs
$this->setXPsForQuestgroup($questgroupId, $xps);
return $xps;
}
/**
* Get the sum of XPs of Quests for a Questgroup solved by a
* Character.
*
* @param int $questgroupId ID of Questgroup
* @param int $characterId ID of Character
* @return int Sum of XPs of Quests
*/
private function _getAchievedXPsForQuestgroup($questgroupId, $characterId)
{
$data = $this->db->query(
'SELECT COALESCE(SUM(quests.xps),0) AS xps '.
'FROM quests '.
'INNER JOIN quests_characters ON quests_characters.quest_id = quests.id AND quests_characters.character_id = ? AND quests_characters.status = ? '.
'WHERE quests.questgroup_id = ?',
'iii',
$characterId,
\hhu\z\models\QuestsModel::QUEST_STATUS_SOLVED,
$questgroupId
);
if(!empty($data)) {
return $data[0]['xps'];
}
}
/*
* Calculate the total amount of achievable XPs for a Quest and
* its following Quests by choosing the path with the highest
* amount of XPs.
*
* @param int $quest Quest data
* @param array $calculatedQuests Already calculated Quests
* @return int Sum of calculated XPs
*/
private function _calculateXPsForQuestgroup($quest, &$calculatedQuests=array())
{
$xps = $quest['xps'];
// Related Questgroups
$relatedQuestgroups = $this->getRelatedQuestsgroupsOfQuest($quest['id']);
foreach($relatedQuestgroups as &$relatedQuestgroup) {
$xps += $this->calculateXPsForQuestgroup($relatedQuestgroup['id'], $calculatedQuests);
}
// Next Quests
$nextQuests = $this->Quests->getNextQuests($quest['id']);
$allNextXPs = array(0);
foreach($nextQuests as &$nextQuest)
{
if(!array_key_exists($nextQuest['id'], $calculatedQuests)) {
$calculatedQuests[$nextQuest['id']] = $this->_calculateXPsForQuestgroup($nextQuest, $calculatedQuests);
}
$allNextXPs[] = $calculatedQuests[$nextQuest['id']];
}
$xps += max($allNextXPs);
return $xps;
}
/**
* Set achievable XPs for a Questgroup.
*
* @param int $questgroupId ID of Questgroup
* @param int $xps XPs to set
*/
private function setXPsForQuestgroup($questgroupId, $xps)
{
$this->db->query(
'UPDATE questgroups '.
'SET achievable_xps = ? '.
'WHERE id = ?',
'ii',
$xps,
$questgroupId
);
}
}
?>

View file

@ -122,10 +122,8 @@
{
// Get Questgroups
$questgroups = $this->Questgroups->getQuestgroupsForHierarchy($hierarchy['id']);
foreach($questgroups as &$questgroup)
{
$data = $this->Questgroups->getCumulatedDataForQuestgroup($questgroup['id']);
$xps += $data['xps'];
foreach($questgroups as &$questgroup) {
$xps += $questgroup['achievable_xps'];
}
}