From 9c9efafc653f2d24c0295db6f1c3528e6d6d5e30 Mon Sep 17 00:00:00 2001 From: oliver Date: Fri, 15 Apr 2016 18:56:58 +0200 Subject: [PATCH] do not reuse pointer (call-by-reference) $drag for editing task of questtype ?Drag&Drop? (fixs #160) --- questtypes/dragndrop/DragndropQuesttypeController.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/questtypes/dragndrop/DragndropQuesttypeController.inc b/questtypes/dragndrop/DragndropQuesttypeController.inc index c9a63b5d..87d76805 100644 --- a/questtypes/dragndrop/DragndropQuesttypeController.inc +++ b/questtypes/dragndrop/DragndropQuesttypeController.inc @@ -256,10 +256,10 @@ if(!is_null($dndField)) { $drags = $this->Dragndrop->getDrags($dndField['quest_id']); - foreach($drags as &$drag) + foreach($drags as &$d) { - $drag['media'] = $this->Media->getSeminaryMediaById($drag['questmedia_id']); - $drag['drops'] = array_map(function($d) { return $d['id']; }, $this->Dragndrop->getDropsForDrag($drag['id'])); + $d['media'] = $this->Media->getSeminaryMediaById($d['questmedia_id']); + $d['drops'] = array_map(function($d) { return $d['id']; }, $this->Dragndrop->getDropsForDrag($d['id'])); } }