ERROR: Failed to load album art #89
Labels
No labels
bug
client
code-quality
duplicate
enhancement
help wanted
in progress
invalid
question
ui
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: coderkun/mcg#89
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Running mcg gives the above error.
Upon first issuing the command I get
(mcg:8455): Gtk-CRITICAL **: 08:49:39.089: gtk_window_add_accel_group: assertion 'GTK_IS_WINDOW (window)' failedOnce the "loading albums" bar completes, and it begins loading images, I get the following
ERROR: Failed to load albumart Traceback (most recent call last): File "/usr/local/share/mcg/mcg/librarypanel.py", line 494, in _set_albums pixbuf = Utils.load_thumbnail(cache, self._client, album, size) File "/usr/local/share/mcg/mcg/utils.py", line 38, in load_thumbnail albumart = client.get_albumart_now(album.get_id()) File "/usr/local/share/mcg/mcg/client.py", line 318, in get_albumart_now (_, albumart) = future.result() TypeError: cannot unpack non-iterable NoneType objectassigned to @coderkun
mentioned in commit
5618c9016c@alan12345678 I pushed a fix for this. Can you check out branch
issue-89-fix-loading-albumartand confirm that the error has been fixed for you?oh! Nice.
I downloaded it and, I hope, dealt with the files correctly...
`$ meson build
The Meson build system
Version: 1.0.0
Source dir: /home//Downloads/mcg-issue-89-fix-loading-albumart
Build dir: /home//Downloads/mcg-issue-89-fix-loading-albumart/build
Build type: native build
Project name: mcg
Project version: 3.1
Host machine cpu family: x86_64
Host machine cpu: x86_64
Program msgfmt found: YES (/usr/bin/msgfmt)
Program desktop-file-validate found: YES (/usr/bin/desktop-file-validate)
Found pkg-config: /usr/bin/pkg-config (1.8.0)
Program glib-compile-resources found: YES (/usr/bin/glib-compile-resources)
Program glib-compile-schemas found: YES (/usr/bin/glib-compile-schemas)
Program python3 found: YES (/usr/bin/python3)
Configuring mcg using configuration
Program msginit found: YES (/usr/bin/msginit)
Program msgmerge found: YES (/usr/bin/msgmerge)
Program xgettext found: YES (/usr/bin/xgettext)
Build-time dependency gio-2.0 found: YES 2.74.4
Program glib-compile-schemas found: YES (/usr/bin/glib-compile-schemas)
Program gtk4-update-icon-cache found: YES (/usr/bin/gtk4-update-icon-cache)
Program update-desktop-database found: YES (/usr/bin/update-desktop-database)
Build targets in project: 8
Found ninja-1.11.1 at /usr/bin/ninja
WARNING: Running the setup command as
meson [options]instead ofmeson setup [options]is ambiguous and deprecated.`
then I did
$ ninja -C build install ninja: Entering directorybuild'[5/6] Installing files.
Installing data/mcg.desktop to /usr/local/share/applications
Installation failed due to insufficient permissions.
Attempting to use polkit to gain elevated privileges...
Installing data/mcg.desktop to /usr/local/share/applications
Installing data/mcg.gresource to /usr/local/share/mcg
Installing po/en/LC_MESSAGES/mcg.mo to /usr/local/share/locale/en/LC_MESSAGES
Installing po/de/LC_MESSAGES/mcg.mo to /usr/local/share/locale/de/LC_MESSAGES
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/data/xyz.suruatoel.mcg.gschema.xml to /usr/local/share/glib-2.0/schemas
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/data/icons/hicolor/scalable/apps/xyz.suruatoel.mcg.svg to /usr/local/share/icons/hicolor/scalable/apps
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/build/src/mcg to /usr/local/bin
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/src/init.py to /usr/local/share/mcg/mcg
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/src/main.py to /usr/local/share/mcg/mcg
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/src/albumheaderbar.py to /usr/local/share/mcg/mcg
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/src/application.py to /usr/local/share/mcg/mcg
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/src/client.py to /usr/local/share/mcg/mcg
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/src/connectionpanel.py to /usr/local/share/mcg/mcg
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/src/coverpanel.py to /usr/local/share/mcg/mcg
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/src/infodialog.py to /usr/local/share/mcg/mcg
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/src/librarypanel.py to /usr/local/share/mcg/mcg
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/src/playlistpanel.py to /usr/local/share/mcg/mcg
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/src/serverpanel.py to /usr/local/share/mcg/mcg
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/src/shortcutsdialog.py to /usr/local/share/mcg/mcg
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/src/utils.py to /usr/local/share/mcg/mcg
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/src/window.py to /usr/local/share/mcg/mcg
Installing /home/alan/Downloads/mcg-issue-89-fix-loading-albumart/src/zeroconf.py to /usr/local/share/mcg/mcg
Running custom install script '/usr/bin/glib-compile-schemas /usr/local/share/glib-2.0/schemas'
Running custom install script '/usr/bin/gtk4-update-icon-cache -q -t -f /usr/local/share/icons/hicolor'
Running custom install script '/usr/bin/update-desktop-database -q /usr/local/share/applications'
`
When I ran it, I got
`$ mcg
(mcg:18206): Gtk-CRITICAL **: 15:35:18.960: gtk_window_add_accel_group: assertion 'GTK_IS_WINDOW (window)' failed`
and after it had finished loading, and failed, I didn't get any of the previous error messages, despite the album display is incorrect (same as before) with most album art missing and showing placeholder only.
Is there anything I should clear out from any ~/.config or ~/.cache etc before launching?
sorry, the code markdown messes up some of the ordered output from terminal
I am pretty sure we can ignore
(mcg:18206): Gtk-CRITICAL **: 15:35:18.960: gtk_window_add_accel_group: assertion 'GTK_IS_WINDOW (window)' failed. If you don’t get any error message anymore, I guess your cover images are simply not found by MPD. Are they named “cover.jpg” or similar?umm.. so, I admit I have been using Cantata until now. As such it has found and displayed every single album cover, and every single track.
I've been using both Kid3 and Picard (Musicbrainz) for over a dozen years. Far as I can see, every single track in my library is fully tagged and with embedded art. MPD seems to be correctly configured. I run a local instance, not system-wide.
I don't ever use per-folder images, and EVERY SINGLE album or track art is labelled "cover.jpg" and in a few instances (e.g. where I need transparency) "cover.png" as embedded. That's all.
CoverGrid currently does not support embedded images. I created #90 to add this feature.