Support embedded cover images #90

New issue

Closed

opened 2023-01-16 10:35:58 +01:00 by coderkun · 6 comments

coderkun commented

2023-01-16 10:35:58 +01:00

(Migrated from gitlab.com)

If no cover image is found via the albumart command, use the readpicture command to load the embedded image (from the first track of the album that has an embedded image).

If no cover image is found via the `albumart` command, use the `readpicture` command to load the embedded image (from the first track of the album that has an embedded image).

coderkun commented

2023-01-16 10:35:59 +01:00

(Migrated from gitlab.com)

assigned to @coderkun

coderkun commented

2023-01-16 10:37:03 +01:00

(Migrated from gitlab.com)

mentioned in issue #89

coderkun commented

2023-01-21 15:37:48 +01:00

(Migrated from gitlab.com)

mentioned in commit 44fb332c62

mentioned in commit 44fb332c62c0677b74e739d7b3ea02e6113ae3d2

coderkun commented

2023-01-21 15:39:26 +01:00

(Migrated from gitlab.com)

@alan12345678, would you be willing to test this feature? It is on branch issue-90-embedded-albumart.

@alan12345678, would you be willing to test this feature? It is on branch `issue-90-embedded-albumart`.

alan12345678 commented

2023-01-21 16:09:08 +01:00

(Migrated from gitlab.com)

absolutely nailed it! Works perfectly! Combined with the ability to sort by "date added" this immediately becomes an entirely viable preferred player 🙂

A couple of remarks (only):

if - a big if - you are developing this as a more "fully-fledged" client, it would be nice to have a couple extra features:

a simple slider or input box to set the pixel width to separate the grid. It looks lovely, but for legibility it's sometimes nice to be able to separate the dense cover grid with some clear padding/borders.

some minimal "right click" controls that allow one to interact directly from the grid. By this I mean a simple option hover over a cover and invoke "play" or "add to queue" or even perhaps "stop/pause". As such there's then no need to extra click into the album itself to set it playing.

All that said - brilliant job!

By way of other comment: I may be atypical, but I've never ever warmed to the dozens of perfectly capable players out there because e.g.

1 they're only playlist based, which is a ball ache if one has a library based on directory structure and not just random tunes thrown into a folder.

2 because they insist on using some specific audio back end, thereby removing most options to directly configure the audio

3 because they offer SO MANY options to display everything e.g. ratings, genres, last played etc. and nany of which cannot be disabled that one ends up with this complex tangle of windows and boxes.

I love this app/client because SIMPLICITY is where it's at for me, and because this way mpd does all the work. It reads the tag info, it talks directly to my sound card. I can configure mpd as I want. Then, CoverGrid just displays my library for me, not try to manage and control it all.

😀

absolutely nailed it! Works perfectly! Combined with the ability to sort by "date added" this immediately becomes an entirely viable preferred player 🙂 A couple of remarks (only): if - a big if - you are developing this as a more "fully-fledged" client, it would be nice to have a couple extra features: a simple slider or input box to set the pixel width to separate the grid. It looks lovely, but for legibility it's sometimes nice to be able to separate the dense cover grid with some clear padding/borders. some minimal "right click" controls that allow one to interact directly from the grid. By this I mean a simple option hover over a cover and invoke "play" or "add to queue" or even perhaps "stop/pause". As such there's then no need to extra click into the album itself to set it playing. All that said - brilliant job! By way of other comment: I may be atypical, but I've never ever warmed to the dozens of perfectly capable players out there because e.g. 1 they're only playlist based, which is a ball ache if one has a library based on directory structure and not just random tunes thrown into a folder. 2 because they insist on using some specific audio back end, thereby removing most options to directly configure the audio 3 because they offer SO MANY options to display everything e.g. ratings, genres, last played etc. and nany of which cannot be disabled that one ends up with this complex tangle of windows and boxes. I love this app/client because SIMPLICITY is where it's at for me, and because this way mpd does all the work. It reads the tag info, it talks directly to my sound card. I can configure mpd as I want. Then, CoverGrid just displays my library for me, not try to manage and control it all. 😀

coderkun commented

2023-01-21 17:15:59 +01:00

(Migrated from gitlab.com)

Thanks for your feedback. I merged this issue and will release a new version.

In general I agree that CoverGrid is missing some features. I will take your feedback into account when planing the next improvements. However, my priority will be GTK 4 (#85).

Thanks for your feedback. I merged this issue and will release a new version. In general I agree that CoverGrid is missing some features. I will take your feedback into account when planing the next improvements. However, my priority will be GTK 4 (#85).