Add check for whether to queue the currently playing album (close #78) #97

Closed

oenometer wants to merge 0 commits from master into master

oenometer commented

2020-10-11 08:36:43 +02:00

(Migrated from gitlab.com)

Check if the album to be played is currently the same as the last album
in the playlist. If so, this album should not be appended to the playlist,
but instead we should just play the first track from the album.

Check if the album to be played is currently the same as the last album in the playlist. If so, this album should not be appended to the playlist, but instead we should just play the first track from the album.

coderkun commented

2020-10-11 10:59:51 +02:00

(Migrated from gitlab.com)

Thanks for your patch, @oenometer. I will test it later today.

coderkun commented

2020-10-11 18:38:01 +02:00

(Migrated from gitlab.com)

I would probably change this check to use the equal operator on the class instead of calling the _id property manually:

if self._playlist and self._playlist[-1] == self._albums[album]:

I would probably change this check to use the equal operator on the class instead of calling the `_id` property manually: if self._playlist and self._playlist[-1] == self._albums[album]:

coderkun commented

2020-10-11 18:40:05 +02:00

(Migrated from gitlab.com)

assigned to @coderkun

oenometer commented

2020-10-12 11:45:30 +02:00

(Migrated from gitlab.com)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/coderkun/mcg/-/merge_requests/1/diffs?diff_id=117520100&start_sha=e5b27fc24266ceff9b7ad0962d2e22da586f530f#ae5a1fb5ef6c7897a2bbbea897696a13beac7037_606_606)

oenometer commented

2020-10-12 11:45:30 +02:00

(Migrated from gitlab.com)

added 1 commit

3301c860 - Moved check for avoiding duplicate tracks in the playlist

Compare with previous version

added 1 commit <ul><li>3301c860 - Moved check for avoiding duplicate tracks in the playlist</li></ul> [Compare with previous version](/coderkun/mcg/-/merge_requests/1/diffs?diff_id=117520100&start_sha=e5b27fc24266ceff9b7ad0962d2e22da586f530f)